dennisthiessenandClaude Opus 5
22bee28ac7
Job outcomes lived only in scheduler._job_runtime, an in-memory dict. Every
deploy wiped it, so Admin -> Jobs could report "Active" with no indication a job
had ever run or how it ended -- which is the main thing that page is for.
New job_run_state table (migration 031): one row per job, upserted on job_name.
Deliberately not history -- system_events already grows unbounded with no
retention job, and a second append-only operational table would repeat that
debt. Adding history later is purely additive.
Written from two hooks, NOT from _runtime_finish. That looked cheapest (one
function, ~40 call sites) but unit tests invoke job coroutines directly, so it
would fire detached DB writes at the real session factory throughout the suite,
and there is no testing flag to guard on.
- An APScheduler EVENT_JOB_EXECUTED/ERROR listener covers everything the
scheduler fires, including manual triggers. Its detached task is held in a
module-level set (a bare create_task result can be collected mid-flight) and
drained in the app lifespan before engine.dispose().
- _run_pipeline persists directly, and must: pipeline steps are plain
coroutine calls that emit no scheduler events, so the listener cannot see
them. The step persist sits AFTER the except that swallows step errors --
inside it, exactly the failed runs worth seeing would be skipped. The
orchestrator persists in the finally, and the disabled early-return persists
too, or "skipped" is silently dropped.
_persist_job_run never raises: a persistence failure must not break an otherwise
successful pipeline.
The API reports this as last_run_* and leaves runtime_* meaning strictly live
in-memory state. Reusing runtime_status would have been a regression, not a
no-op: JobControls drives the status chip from it (a job that errored eight days
ago would read "Last run error" forever instead of "Active") and picks the
rate-limit banner from it (a week-old rate limit would pin the banner
permanently). Tests pin the split.
The table starts empty; each job fills its row the next time it finishes. No
backfill from system_events, which records only warning/error outcomes under a
different status vocabulary and would invent successes that never happened.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
48 lines
1.5 KiB
Python
48 lines
1.5 KiB
Python
from app.models.ticker import Ticker
|
|
from app.models.ohlcv import OHLCVRecord
|
|
from app.models.user import User
|
|
from app.models.sentiment import SentimentScore
|
|
from app.models.fundamental import FundamentalData
|
|
from app.models.fundamental_snapshot import FundamentalSnapshot
|
|
from app.models.earnings_event import EarningsEvent
|
|
from app.models.data_import_run import DataImportRun
|
|
from app.models.score import DimensionScore, CompositeScore
|
|
from app.models.sr_level import SRLevel
|
|
from app.models.trade_setup import TradeSetup
|
|
from app.models.watchlist import WatchlistEntry
|
|
from app.models.settings import SystemSetting, IngestionProgress
|
|
from app.models.alert import AlertLog
|
|
from app.models.paper_trade import PaperTrade
|
|
from app.models.regime_snapshot import RegimeSnapshot
|
|
from app.models.benchmark_price import BenchmarkPrice
|
|
from app.models.signal_context_snapshot import SignalContextSnapshot
|
|
from app.models.system_event import SystemEvent
|
|
from app.models.sec_filing_gap import SecFilingGap
|
|
from app.models.job_run_state import JobRunState
|
|
|
|
__all__ = [
|
|
"Ticker",
|
|
"OHLCVRecord",
|
|
"User",
|
|
"SentimentScore",
|
|
"FundamentalData",
|
|
"FundamentalSnapshot",
|
|
"EarningsEvent",
|
|
"DataImportRun",
|
|
"DimensionScore",
|
|
"CompositeScore",
|
|
"SRLevel",
|
|
"TradeSetup",
|
|
"WatchlistEntry",
|
|
"SystemSetting",
|
|
"IngestionProgress",
|
|
"AlertLog",
|
|
"PaperTrade",
|
|
"RegimeSnapshot",
|
|
"BenchmarkPrice",
|
|
"SignalContextSnapshot",
|
|
"SystemEvent",
|
|
"SecFilingGap",
|
|
"JobRunState",
|
|
]
|