2 Commits

Include renames

Author	SHA1	Message	Date
dennisthiessenandClaude Opus 5	34299bce54	fix: follow-up review corrections, BIS rejection, and a gitignore miss ... Second-pass review of this session's work by another agent. It corrected several real mistakes of mine and finished F06 gaps I had left open. Reviewed, verified and committed as-is. THE MISS THAT MATTERS `job_scout/state/applications.json` — the authoritative application registry introduced by F02 — was never actually tracked. `job_scout/state/*` in .gitignore silently excluded it, so my checkpoint commit afdef7e claimed to add it and did not. Only `application_cohort.json`, the GENERATED projection, was version-controlled; the source of truth and the migration history backup were not. .gitignore now carries explicit negations for both. MY ERRORS, CORRECTED - "kastellaun" was in CH_LOCATION_KEYWORDS. Kastellaun is in Rhineland-Palatinate. I took it from a Bundeswehr reserve listing and filed it under Switzerland - precisely the class of bug F12 existed to fix. - The F12 fix only widened the keyword list; SmartRecruiters still discarded the structured country, which was the concrete case the review named (city=Baar, country=CH). The adapter now preserves it, and a COUNTRY_NAMES mapping gives country precedence over a bare town name. - F15 was applied to Taleo and Prospective only. Greenhouse still wrote `updated_at` into `posted`; it now uses `published_at` and carries provenance. - My negation guard `\b(no|not|...)\b[^.;]{0,60}$` was too loose - an unrelated "not" within 60 characters could mask a real claim. Tightened to require the negation to govern the term. - F18's retirement of the macro-count rule missed "Four to six compact skills lines" in the workflow; removed now. F06 GAPS I LEFT OPEN, NOW CLOSED Date-format validation on education/employment periods (the 2035-99 case named in the review), evidence-structure validation, referential integrity on evidence source files, and the missing-identity KeyError. F10 TAKEN FURTHER, AND RIGHTLY I demoted the US-GPA fields to *_orientation_only. They are now removed entirely, with grade_output_rule saying what to do instead: use the German grade and scale, and if a recipient requires a US GPA, use THEIR method and record it. Keeping a number derived by a non-recognised method invites its use. Also: the Capgemini omit-preference now sits in experience_capgemini.md itself, alongside the instruction not to fill or explain the intentional gap. BIS BASEL - REJECTED 2026-09-11 jr100429, applied 2026-07-10, no interview, no reason given. Recorded in the registry with a dated event and in the decision log; the "prep interview brief when screening lands" next action is cleared. This also settles the 2026-09-04 observation that the req had vanished from the BIS board - it was a real rejection, not just a closed posting. VERIFICATION I RAN MYSELF BEFORE COMMITTING 49/49 tests. Validator PASS with 0 advisory warnings. Package manifest and registry views current. All 12 F12 location cases still correct, including Kastellaun now rejecting. The F05 counter-proof still catches all 9 violations. SBB, NVIDIA, RUAG and Kdo Cy resumes still scan clean. Diffs are net-additive across every reference file - the deletions are replacements, not losses. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qej5SBvhcbGXHwLqNWiskM	2026-09-11 23:57:06 +02:00
dennisthiessenandClaude Opus 5	b8c5141279	fix(F18-F19): get evidence onto page one earlier, measured not asserted ... F18 - page-one weighting - Across four compiled packages the first employment entry began at 45-55% of page one. A reader reaching the middle of the page had seen a profile and a skills block, and no evidence. - The old skills rule counted `\skillline` MACROS, which does not control density: six categories with long value lists wrap to twelve or more rendered lines. Replaced with a rendered-line budget verified in the compiled PDF, plus the rule that a skills line repeating what three bullets below already prove is spending the first screen to say it twice. - Employer chronology stays reverse-chronological; the ordering freedom is WITHIN a position, where the bullet closest to the target role leads. - New helper `page_metrics.py` measures page-one geometry from the PDF via pdftotext -bbox. F19 - education and phrasing - Degree + focus + institution crammed into one cell with a right-aligned date produced visible word spacing and mid-word breaks in SBB, NVIDIA and Aker BP. Split the entry, as RUAG_AI_Engineer_C5I already did. Template carries the rule. - Grades and thesis stay only where concretely relevant. claims.json grade_output_rule already keeps grades off by default; the M.Eng. thesis earns its place on condition-monitoring or sensor-data roles and otherwise does not. Validated by measurement rather than assertion - page_metrics.py first reproduced the review's own figures (NVIDIA 55.4%, SBB 50.6%, RUAG 50.3%). That is what makes the after-figure meaningful. - The NVIDIA CV was rebuilt FROM A COPY with the guidance applied: experience moved 55.4% -> 44.0% of page one, page-one text lines 47 -> 39, still two pages, zero overfull boxes, validator PASS. - The submitted package itself was not modified. F17 classifies archives as evidence, not as drafts. The percentage is a diagnostic, not a target: no pixel goal and no rule that page two must be filled. All 19 review findings are now complete. 37/37 tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qej5SBvhcbGXHwLqNWiskM	2026-09-11 20:56:17 +02:00