2 Commits

Include renames

Author	SHA1	Message	Date
dennisthiessenandClaude Opus 5	34299bce54	fix: follow-up review corrections, BIS rejection, and a gitignore miss ... Second-pass review of this session's work by another agent. It corrected several real mistakes of mine and finished F06 gaps I had left open. Reviewed, verified and committed as-is. THE MISS THAT MATTERS `job_scout/state/applications.json` — the authoritative application registry introduced by F02 — was never actually tracked. `job_scout/state/*` in .gitignore silently excluded it, so my checkpoint commit afdef7e claimed to add it and did not. Only `application_cohort.json`, the GENERATED projection, was version-controlled; the source of truth and the migration history backup were not. .gitignore now carries explicit negations for both. MY ERRORS, CORRECTED - "kastellaun" was in CH_LOCATION_KEYWORDS. Kastellaun is in Rhineland-Palatinate. I took it from a Bundeswehr reserve listing and filed it under Switzerland - precisely the class of bug F12 existed to fix. - The F12 fix only widened the keyword list; SmartRecruiters still discarded the structured country, which was the concrete case the review named (city=Baar, country=CH). The adapter now preserves it, and a COUNTRY_NAMES mapping gives country precedence over a bare town name. - F15 was applied to Taleo and Prospective only. Greenhouse still wrote `updated_at` into `posted`; it now uses `published_at` and carries provenance. - My negation guard `\b(no|not|...)\b[^.;]{0,60}$` was too loose - an unrelated "not" within 60 characters could mask a real claim. Tightened to require the negation to govern the term. - F18's retirement of the macro-count rule missed "Four to six compact skills lines" in the workflow; removed now. F06 GAPS I LEFT OPEN, NOW CLOSED Date-format validation on education/employment periods (the 2035-99 case named in the review), evidence-structure validation, referential integrity on evidence source files, and the missing-identity KeyError. F10 TAKEN FURTHER, AND RIGHTLY I demoted the US-GPA fields to *_orientation_only. They are now removed entirely, with grade_output_rule saying what to do instead: use the German grade and scale, and if a recipient requires a US GPA, use THEIR method and record it. Keeping a number derived by a non-recognised method invites its use. Also: the Capgemini omit-preference now sits in experience_capgemini.md itself, alongside the instruction not to fill or explain the intentional gap. BIS BASEL - REJECTED 2026-09-11 jr100429, applied 2026-07-10, no interview, no reason given. Recorded in the registry with a dated event and in the decision log; the "prep interview brief when screening lands" next action is cleared. This also settles the 2026-09-04 observation that the req had vanished from the BIS board - it was a real rejection, not just a closed posting. VERIFICATION I RAN MYSELF BEFORE COMMITTING 49/49 tests. Validator PASS with 0 advisory warnings. Package manifest and registry views current. All 12 F12 location cases still correct, including Kastellaun now rejecting. The F05 counter-proof still catches all 9 violations. SBB, NVIDIA, RUAG and Kdo Cy resumes still scan clean. Diffs are net-additive across every reference file - the deletions are replacements, not losses. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qej5SBvhcbGXHwLqNWiskM	2026-09-11 23:57:06 +02:00
dennisthiessenandClaude Opus 5	eecdbdade6	fix(F17): a PDF in a folder is not proof the package can be rebuilt ... Build sweep run this session: 48 sources, 46 built, 2 failed. Infineon_AI_Engineer's cover letter fails on font expansion (the font is not scalable); cv_template.tex fails on unfilled placeholders, which is expected for the academic legacy path. Overfull boxes: Microsoft ISE 25.33pt, Isovalent 0.88pt. All historical, all left alone. New: resume_builder/helpers/package_manifest.py records, per application package, what a rebuild would ACTUALLY do - sources, class-file hashes, PDFs present, and the reasons a rebuild would not reproduce the submitted document. It is descriptive; nothing in it authorises rewriting a submitted file. What it found across 21 packages: - 17 are DATE-DEPENDENT. The cover letters use oday, so recompiling a historical package silently restamps it with today's date. - 1 has an INCOMPLETE SOURCE DISTRIBUTION: output/NATO_AI_ENGINEER ships no resume.cls. It builds on this machine only because a copy exists elsewhere, and the shipped PDF hid that. Not repaired by copying the newest class in - the repo carries THREE different resume.cls variants (13/7/1 copies) and older macros differ, so that "fix" could silently change a historical document. - 1 has no PDF at all, so nothing is reviewable without a build. Classification: 7 application packages were in no reuse category. Added to historical_revalidate, and the register now records the default explicitly - anything unlisted is treated as revalidate-before-reuse. Being recent is not the same as being verified; none of the seven was re-read for this. Prevention rather than repair: oday removed from the cover-letter template so new packages stop adding to the pile. A test now fails if it comes back, if the manifest goes stale, or if a package is left unclassified. Also: scan_document gained a template mode. A placeholder in a TEMPLATE is what makes it a template; the defect is one surviving into a generated document. 37/37 tests pass; counter-proof still catches all 9. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qej5SBvhcbGXHwLqNWiskM	2026-09-11 20:48:52 +02:00