Optional tighteners
Off by default — turn on to be more selective on top of the momentum gate.
diff --git a/frontend/src/lib/qualification.ts b/frontend/src/lib/qualification.ts index 7d74da6..9ced85d 100644 --- a/frontend/src/lib/qualification.ts +++ b/frontend/src/lib/qualification.ts @@ -42,6 +42,8 @@ export function qualifiesSetup(setup: TradeSetup, config: ActivationConfig): boo return false; } } + // NEUTRAL = "no clear setup" — not actionable, so by default it doesn't qualify. + if (config.exclude_neutral && (setup.recommended_action ?? 'NEUTRAL') === 'NEUTRAL') return false; if (config.require_high_conviction && !HIGH_CONVICTION_ACTIONS.has(setup.recommended_action ?? '')) { return false; } @@ -74,6 +76,7 @@ export function activationSummary(config: ActivationConfig): string { const parts = []; if (config.min_momentum_percentile > 0) parts.push(`top ${(100 - config.min_momentum_percentile).toFixed(0)}% momentum`); parts.push(`R:R ≥ ${config.min_rr.toFixed(1)}`, `conf ≥ ${config.min_confidence.toFixed(0)}%`); + if (config.exclude_neutral) parts.push('directional'); if (config.require_high_conviction) parts.push('high-conviction'); if (config.exclude_conflicts) parts.push('clean'); return parts.join(' · '); diff --git a/frontend/src/lib/types.ts b/frontend/src/lib/types.ts index 8765341..25eabfb 100644 --- a/frontend/src/lib/types.ts +++ b/frontend/src/lib/types.ts @@ -166,6 +166,7 @@ export interface ActivationConfig { min_confidence: number; require_high_conviction: boolean; exclude_conflicts: boolean; + exclude_neutral: boolean; } // Cron schedule for the daily/intraday pipelines + fundamentals diff --git a/tests/unit/test_activation_settings.py b/tests/unit/test_activation_settings.py index 5ad2810..5f7d1da 100644 --- a/tests/unit/test_activation_settings.py +++ b/tests/unit/test_activation_settings.py @@ -30,6 +30,7 @@ class TestActivationConfig: "min_confidence": 55.0, "require_high_conviction": False, "exclude_conflicts": False, + "exclude_neutral": True, } async def test_update_and_read_back(self, session: AsyncSession): @@ -62,6 +63,12 @@ class TestActivationConfig: assert config["require_high_conviction"] is True assert config["exclude_conflicts"] is True + async def test_exclude_neutral_round_trip(self, session: AsyncSession): + # On by default; can be turned off. + assert (await get_activation_config(session))["exclude_neutral"] is True + await update_activation_config(session, {"exclude_neutral": False}) + assert (await get_activation_config(session))["exclude_neutral"] is False + async def test_rejects_negative_rr(self, session: AsyncSession): with pytest.raises(ValidationError): await update_activation_config(session, {"min_rr": -1.0}) diff --git a/tests/unit/test_qualification.py b/tests/unit/test_qualification.py index d57d0bb..110fa6f 100644 --- a/tests/unit/test_qualification.py +++ b/tests/unit/test_qualification.py @@ -111,6 +111,24 @@ class TestStrictTighteners: assert setup_qualifies(s, STRICT_GATE) is False +NEUTRAL_GATE = {**DEFAULT_GATE, "exclude_neutral": True} + + +class TestExcludeNeutral: + def test_neutral_excluded_when_on(self): + assert setup_qualifies(_setup(recommended_action="NEUTRAL"), NEUTRAL_GATE) is False + + def test_missing_action_treated_as_neutral(self): + assert setup_qualifies(_setup(recommended_action=None), NEUTRAL_GATE) is False + + def test_directional_passes_when_on(self): + assert setup_qualifies(_setup(recommended_action="LONG_MODERATE"), NEUTRAL_GATE) is True + + def test_neutral_allowed_when_off(self): + # Flag absent from the config → NEUTRAL still qualifies (backward compatible). + assert setup_qualifies(_setup(recommended_action="NEUTRAL"), DEFAULT_GATE) is True + + class TestBestTargetProbability: def test_returns_max(self): s = _setup(targets=[{"probability": 40.0}, {"probability": 72.0}, {"probability": 55.0}])