feat: ticker search, watchlist momentum column, alpha vs S&P 500
Three usability fixes: 1. Global ticker search in the sidebar (TickerSearch) — typeahead over the tracked universe that opens a ticker's detail page without adding it to the watchlist. Also wired into the mobile nav. 2. Watchlist table shows the ticker's 12-1 momentum percentile (the top-pick selector) instead of the noisy full S/R-level list. Enriched from the setup already loaded in watchlist_service._enrich_entry — no extra query. 3. Alpha vs the S&P 500 on paper trades (open + closed). New benchmark_prices table + benchmark_service store SPY daily closes (a standalone series, not a Ticker, so it never enters the scanner / momentum ranking / rankings) via a new daily-pipeline step. paper_trade_service computes per-trade benchmark_return / alpha_pct / alpha_usd over each holding period; the open- trades table, dashboard, and closed-trades panel surface per-trade and total alpha. The list read path never makes a provider call. Deploy: alembic upgrade head, then run the benchmark/daily job once to populate SPY closes (alpha shows "—" until then). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -7,7 +7,9 @@ from datetime import date, datetime, timedelta, timezone
|
||||
import pytest
|
||||
|
||||
from app.exceptions import ValidationError
|
||||
from app.models.benchmark_price import BenchmarkPrice
|
||||
from app.models.ohlcv import OHLCVRecord
|
||||
from app.models.paper_trade import PaperTrade
|
||||
from app.models.ticker import Ticker
|
||||
from app.models.user import User
|
||||
from app.services import paper_trade_service as svc
|
||||
@@ -124,3 +126,48 @@ async def test_resolve_leaves_open_when_neither_hit(session):
|
||||
assert closed == 0
|
||||
rows = await svc.list_trades(session, 1, status="open")
|
||||
assert len(rows) == 1
|
||||
|
||||
|
||||
async def _seed_benchmark(session, points: dict) -> None:
|
||||
for d, close in points.items():
|
||||
session.add(BenchmarkPrice(symbol="SPY", date=d, close=close))
|
||||
await session.commit()
|
||||
|
||||
|
||||
async def _add_open_trade(session, ticker_id: int, direction: str, *, entry: float,
|
||||
shares: float, days_ago: int) -> None:
|
||||
session.add(PaperTrade(
|
||||
user_id=1, ticker_id=ticker_id, direction=direction, entry_price=entry,
|
||||
shares=shares, stop_loss=entry * 0.95, target=entry * 1.2, status="open",
|
||||
opened_at=datetime.now(timezone.utc) - timedelta(days=days_ago),
|
||||
))
|
||||
await session.commit()
|
||||
|
||||
|
||||
async def test_alpha_long_open(session):
|
||||
tid = await _seed(session, "AAA", close=110.0) # current price 110 → +10% on a 100 entry
|
||||
today = date.today()
|
||||
await _seed_benchmark(session, {today - timedelta(days=10): 400.0, today: 420.0}) # SPY +5%
|
||||
await _add_open_trade(session, tid, "long", entry=100.0, shares=10, days_ago=10)
|
||||
|
||||
row = (await svc.list_trades(session, 1, status="open"))[0]
|
||||
assert row["benchmark_return_pct"] == pytest.approx(5.0)
|
||||
assert row["alpha_pct"] == pytest.approx(5.0) # +10% trade − 5% bench
|
||||
assert row["alpha_usd"] == pytest.approx(50.0) # 5% of 100*10
|
||||
|
||||
|
||||
async def test_alpha_short_and_missing_benchmark(session):
|
||||
tid = await _seed(session, "BBB", close=90.0) # price fell to 90 → short +10%
|
||||
today = date.today()
|
||||
await _add_open_trade(session, tid, "short", entry=100.0, shares=4, days_ago=10)
|
||||
|
||||
# No benchmark data yet → alpha unset, not an error.
|
||||
row = (await svc.list_trades(session, 1, status="open"))[0]
|
||||
assert row["alpha_pct"] is None
|
||||
assert row["benchmark_return_pct"] is None
|
||||
|
||||
# Flat benchmark → alpha equals the (direction-signed) trade return.
|
||||
await _seed_benchmark(session, {today - timedelta(days=10): 400.0, today: 400.0})
|
||||
row = (await svc.list_trades(session, 1, status="open"))[0]
|
||||
assert row["benchmark_return_pct"] == pytest.approx(0.0)
|
||||
assert row["alpha_pct"] == pytest.approx(10.0)
|
||||
|
||||
Reference in New Issue
Block a user